Make gases flow up.#5021
Open
screret wants to merge 48 commits into
Open
Conversation
…ole ScopedValue being thread local
its like 1.12 Thermal Expansion energized glowstone!!!
…ing block checks on the Y axis if we're rendering fluids upside down
…placed from a bucket
…its `getDescription` implementation(s)
(Duplicate means they're supposed to be in modularui and got left behind here for whatever reason)
* custom textures not included.
…fferent suffixes for a texture
…to assign correct values to that
the VertexConsumer class got way out of hand IMO.
…ng being off by one
…own fluids are shaded nicely
…nsions.sodium.BlockOcclusionCacheExt
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
As the title says. Fluids with negative (or zero, forge says so) density flow up.
Well, technically, gases evaporate instantly so you won't get to see them flow up. Neutronium doesn't, though, so that's currently the one and only example of a fluid flowing up.
There are configs for disabling gas evaporation, upside-down fluid flow and upside-down fluid rendering respectively. Disabling rendering without disabling the gameplay mechanics will likely result in VERY weird-looking fluids, tough, so users beware: that is intentional, you shouldn't disable only the client config unless you're having issues whilst playing on a server and you can mind the oddities that'll ensue.
Implementation Details
Mixins into Vanilla's, Sodium's and Embeddium's fluid renderers to make them handle rendering the fluid upside down and overriding literally every flow handling method from
FlowingFluid.AI Usage
Outcome
Haha look the neutronium flows up now
How Was This Tested
Vanilla:
Sodium:
Embeddium:
(They all look the same, but from different angles and/or distances)
Additional Information
All GT fluids now have blocks by default, as I felt there was no reason to gatekeep that anymore.
Potential Compatibility Issues
Mods that don't expect fluids to flow up (all of them, really) may have issues with this. If you find one, disable
gameplay.lowDensityFluidsFlowUpin the config.